Update transaction input loader logic for ConsensusV2 objects #21634
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Previously this did not correctly account for the possibility of `initial_shared_version` not matching between the requested input and the object that was loaded.
aschran
force-pushed
the
aschran/cov2-loading
branch
from
347d88a to
6b7ed6e
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
| Self::ImmOrOwnedMoveObject((id, _, _)) => *id, | ||
| Self::SharedMoveObject { id, .. } => *id, | ||
| Self::MovePackage(id) => FullObjectID::Fastpath(*id), | ||
| Self::ImmOrOwnedMoveObject((id, _, _)) => FullObjectID::Fastpath(*id), |
There was a problem hiding this comment.
nit: i think it would be better to call it QualifiedObjectID instead of FullObjectID, because this stuff isn't really part of the ID itself, its a function of how we are referring to it
There was a problem hiding this comment.
discussed on chat, but response for posterity
The prefix Full* as a term used to refer to the complete object identifier inclusive of both the address and the start_version for consensus objects was introduced a couple months ago already in #20822
Fair enough if you want to reopen the discussion on that naming choice, but it would be a broad rename across like 20 files that is not really related to this particular PR
2 participants
Previously this did not correctly account for the possibility of
initial_shared_versionnot matching between the requested input and the object that was loaded.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.