[move][move-vm][rewrite][cleanup 3/n] Replace index references with VM Pointers #21213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
reviewed
Feb 19, 2025
external-crates/move/crates/move-vm-runtime/src/execution/dispatch_tables.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/jit/execution/translate.rs
Show resolved
Hide resolved
| DUPLICATE_NATIVE_FUNCTION = 2022, | ||
| ARITHMETIC_OVERFLOW = 2023, | ||
| DUPLICATE_TYPE_DEFINITION = 2050, | ||
| VTABLE_KEY_LOOKUP_ERROR = 2033, |
There was a problem hiding this comment.
I'd probably change this to a different number, it feels like 2024 or 2051 would fit better.
Also, why is there a jump from 2023 to 2050... 🤔
external-crates/move/crates/move-vm-runtime/src/jit/execution/ast.rs
Outdated
Show resolved
Hide resolved
| module_name, | ||
| member_name, | ||
| }, | ||
| match &self.datatype_info.inner_ref() { |
There was a problem hiding this comment.
Isn't this the same as qualified_name above? Understandable if you don't want to remove this in this PR, but maybe add a TODO for it (or reuse it)
Comment on lines
+1014
to
+1016
| Datatype::Enum(ptr) => ptr.def_vtable_key.inner_pkg_key, | ||
| Datatype::Struct(ptr) => ptr.def_vtable_key.inner_pkg_key, | ||
| } |
There was a problem hiding this comment.
Consider rewriting in terms of qualified_name possibly
There was a problem hiding this comment.
That would technically clone the whole key instead of just the inner key, which is a much larger copy.
cgswords
force-pushed
the
cgswords/vm_pointer_exec
branch
from
3418245 to
5e0a343
Compare
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors a large part of the execution AST in order to change every index in the bytecode to use a VM pointer instead. On the way, we also completely revised how types are stored in vtables and wrote down type definition IDs. The tracer and evaluator got much-simplified, but the translation had to change dramatically to accommodate.
Test plan
All the tests still pass. I plan to use ASAN / valgrind on this code in the coming days to ensure no memory is leaked.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.