[12/n][vm-rewrite] Update and cleanup linkage generation #21167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-12
branch
from
2f45381 to
8704f63
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This updates linkage generation to almost always include system packages (other than in genesis/system transaction mode -- so basically when we're updating the system packages). This is primarily since we rely on access to these packages at places in the adapter (e.g., when resolving the type for the upgrade capability when upgrading or publishing a package). This also cleans up the interfaces around linkage
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-11
branch
from
7b669ec to
719f29b
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-12
branch
from
8704f63 to
9846ab1
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates linkage generation to almost always include system packages (other than in genesis/system transaction mode -- so basically when we're updating the system packages). This is primarily since we rely on access to these packages at places in the adapter (e.g., when resolving the type for the upgrade capability when upgrading or publishing a package).
This also cleans up the interfaces around linkage
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.