[3/n][vm-rewrite][Move] Update native context extensions to support Cloning #21067
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-2
branch
from
c07295c to
1c7a767
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-3
branch
from
a1a87a0 to
bba3dc9
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-3
branch
from
bba3dc9 to
e390092
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
| /// | ||
| /// Note that this is _not_ threadsafe. If you need threadsafe access to the `T` you will need to | ||
| /// handle that within `T'`s type (just like in the previous implementation of the | ||
| /// `NativeContextExtensions`). |
There was a problem hiding this comment.
I am a little confused. It appears we are making it so that all mutability needs to be explicit when building up the native context extension, whereas before everything was arbitrarily mutable. What is the motivation for this change?
There was a problem hiding this comment.
In the discussions we had about how we wanted to change this, the consensus that I gathered is that we wanted to move to this model where the native context extensions do not make any guarantees about mutability, or directly support interior mutability itself, but instead the decision around how to (or not to) support any type of mutability would be a per-extension decisions, and the extension would need to be explicit about how, and if, it will support mutability.
I think this is generally a better place to be as it makes it much clearer from the perspective of a user of the native extensions about how/if you want to support mutability for the extension (do you want a Mutex for some reason? Maybe no mutability, etc).
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-3
branch
from
e390092 to
24d2724
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
external-crates/move/crates/move-vm-runtime/src/natives/extensions.rs
Outdated
Show resolved
Hide resolved
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…loning, and let extension determine how to handle interior mutability. This updates the `NativeContextExtensions` struct to be `Clone`able. This updates the `Box<dyn Tid<'a>>` to a `Rc<dyn Tid<'a>>` and the extension is responsible for handling interior mutability. As a helper struct the `NativeContextMut` was added to allow for easy writing/handling of native extensions that need interior mutability. NB: The code in the PR may not be working as future PRs will build on top of this. In particular, for this PR, the changes to the object runtime/sui-adapter/sui-execution natives will be needed.
…pport Cloning, and let extension determine how to handle interior mutability.
…s to support Cloning, and let extension determine how to handle interior mutability.
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-2
branch
from
5e307e9 to
63b45c3
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-3
branch
from
dfc68d7 to
f9e0f31
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
merged into the |
3 participants
This updates the
NativeContextExtensionsstruct to beCloneable. This updates theBox<dyn Tid<'a>>to aRc<dyn Tid<'a>>and the extension is responsible for handling interior mutability.As a helper struct the
NativeContextMutwas added to allow for easy writing/handling of native extensions that need interior mutability.NB: The code in the PR may not be working as future PRs will build on top of this. In particular, for this PR, the changes to the object runtime/sui-adapter/sui-execution natives will be needed.