[1/n][vm-rewrite][Move] Updates to VM: some bugfixes, and query functions on vm instances needed for the adapter. #21065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
reviewed
Feb 4, 2025
external-crates/move/crates/move-vm-runtime/src/execution/vm.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Feb 4, 2025
external-crates/move/crates/move-vm-runtime/src/jit/execution/translate.rs
Show resolved
Hide resolved
cgswords
reviewed
Feb 4, 2025
external-crates/move/crates/move-vm-runtime/src/natives/functions.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Feb 4, 2025
| pub mod tracing; | ||
| pub mod values; | ||
| pub mod vm; | ||
| pub use crate::jit::execution::ast::Type; |
There was a problem hiding this comment.
Sensible, I suppose -- where is this used?
There was a problem hiding this comment.
This is used in parts of the adapter since we need to look at the Types in the LoadedFunctionInformation to determine whether arguments to a function are references or not.
If we add something like TypeTagWithRefs, we could probably remove this exposure.
cgswords
approved these changes
Feb 4, 2025
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-1
branch
from
30e5561 to
dbf5e6d
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…ions on vm instances needed for the adapter. This adds various "query" functions that the Sui adapter will need to the VM (e.g., resolving a typetag to a loaded type, getting type layouts, abilities, etc). As part of this it adds a `LoadedFunctionInformation` struct that allows VM runtime `Type`s to flow out of the VM. The adapter and object runtime will need to (and does) take care to not allow these VM runtime types to flow across VM instance boundaries. The code in the PR may not be working as future PRs will build on top of this.
…y functions on vm instances needed for the adapter.
…nd query functions on vm instances needed for the adapter.
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-0
branch
from
ced69b5 to
ea01d5f
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-1
branch
from
dbf5e6d to
65e799e
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds various "query" functions that the Sui adapter will need to the VM (e.g., resolving a typetag to a loaded type, getting type layouts, abilities, etc). As part of this it adds a
LoadedFunctionInformationstruct that allows VM runtimeTypes to flow out of the VM. The adapter and object runtime will need to (and does) take care to not allow these VM runtime types to flow across VM instance boundaries.The code in the PR may not be working as future PRs will build on top of this.