[0/n][vm-rewrite][Move] Add runtime_id to SerializedPackage and remove old MoveResolver trait
#21064
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
| } | ||
|
|
||
| for m_bytes in package.modules { | ||
| for (nm, m_bytes) in package.modules { |
There was a problem hiding this comment.
Nit: use a real name, I have no idea what nm means here.
|
|
||
| /// The `SerializedPackage` struct holds the serialized modules of a package, the storage ID of the | ||
| /// package, and the linkage table that maps the runtime ID found within the package to their | ||
| /// storage IDs. |
There was a problem hiding this comment.
Should this come live in move-vm-runtime eventually?
There was a problem hiding this comment.
Possilby, or other stuff from the move-vm-runtime will need to move here (or some in-between state). We're going to need to have an execution versioning discussion about the move-vm-runtime crate and where types live as that was cropping up higher up as well for some other types.
| /// storage IDs. | ||
| #[derive(Debug, Clone)] | ||
| pub struct SerializedPackage { | ||
| pub modules: Vec<Vec<u8>>, |
There was a problem hiding this comment.
I am a little dubious about this change: we have previously discussed init relying on this order (which is currently sorted based on dependencies), and we need to consider how init and init_with_args will look with these changes.
| /// (this is not currently possible as ModuleId and StructTag | ||
| /// are always structurally valid) | ||
| /// - storage encounters internal error | ||
| pub trait ModuleResolver { |
There was a problem hiding this comment.
Nit: this should be a PackageResolver now
|
Good point on the module ordering. I think switching over to an |
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
force-pushed
the
cgswords/vm_pointer_exec
branch
from
1417a14 to
53c073f
Compare
…emove old `MoveResolver` trait This adds the `runtime_id` to the `SerializedPackage` struct, changes the module bytes in the `SerializedPackage` to be a `BTreeMap` from the module name to the modules bytes (making module resolution faster and more efficient for certain operations), and removes the old `MoveResolver` trait as it was no longer needed for the new VM, The code in the PR may not be working as future PRs will build on top of this.
…` and remove old `MoveResolver` trait
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-0
branch
from
ced69b5 to
ea01d5f
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
force-pushed
the
cgswords/vm_pointer_exec
branch
from
3418245 to
5e0a343
Compare
|
merged into the |
2 participants
This adds the
runtime_idto theSerializedPackagestruct, changes the module bytes in theSerializedPackageto be aBTreeMapfrom the module name to the modules bytes (making module resolution faster and more efficient for certain operations), and removes the oldMoveResolvertrait as it was no longer needed for the new VM,The code in the PR may not be working as future PRs will build on top of this.