[move][move-vm][rewrite][cleanup 2/n] Add limits to arena and string interner #21050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
force-pushed
the
cgswords/vm_pointer_singatures
branch
from
9730949 to
87b80cc
Compare
tzakian
reviewed
Feb 4, 2025
Comment on lines
55
to
59
| std::ptr::copy_nonoverlapping(items.as_ptr(), mut_ptr, len); | ||
| } | ||
|
|
||
| // Prevent the original vector from dropping its data | ||
| std::mem::forget(items); |
There was a problem hiding this comment.
This doesn't seem right to me. Since we're copying the elements of items over and then the std::mem::forget on items will leak them. I think this should be an explicit drop no?
There was a problem hiding this comment.
Agreed -- see the follow-on PR.
external-crates/move/crates/move-vm-runtime/src/cache/identifier_interner.rs
Outdated
Show resolved
Hide resolved
|
There does appear to be a possible memory leak. I have updated bumpalo and reverted the change in this PR. There will be a new PR that does things appropriately. |
cgswords
force-pushed
the
cgswords/vm_arena_limits
branch
from
ca7cf22 to
dbcd7d5
Compare
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
changed the base branch from
cgswords/vm_pointer_singatures
to
cgsworsd/vm_rewrite_jit_opt
cgswords
added a commit
that referenced
this pull request
Feb 5, 2025
…interner (#21050) ## Description This sets limits for arenas and the string interner, producing errors if allocation fails. ## Test plan All tests still pass --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
cgswords
added a commit
that referenced
this pull request
Feb 5, 2025
) This sets limits for arenas and the string interner, producing errors if allocation fails. All tests still pass --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets limits for arenas and the string interner, producing errors if allocation fails.
Test plan
All tests still pass
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.