Skip to content

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented Jan 17, 2025

Description

Update how we handle deserialization errors so they maintain their specificity. Also updates a bad merge.

Test plan

CI


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@tzakian tzakian requested a review from cgswords January 17, 2025 19:54
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 8:34pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 8:34pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 8:34pm

@tzakian tzakian temporarily deployed to sui-typescript-aws-kms-test-env January 17, 2025 20:32 — with GitHub Actions Inactive
@tzakian tzakian changed the title [vm-rewrite] Update deserialization errors to be more specific [vm-rewrite] Fix tests Jan 17, 2025
Copy link
Contributor

@cgswords cgswords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgswords cgswords merged commit 1a343dc into tzakian/rootless-linkage Jan 18, 2025
30 of 52 checks passed
@cgswords cgswords deleted the tzakian/deser-errors branch January 18, 2025 00:06
tzakian added a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants