[vm-rewrite] Rootless linkage #20916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/rootless-linkage
branch
from
32edf06 to
3f841af
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
reviewed
Jan 17, 2025
external-crates/move/crates/move-cli/src/sandbox/utils/on_disk_state_view.rs
Show resolved
Hide resolved
cgswords
reviewed
Jan 18, 2025
external-crates/move/crates/move-transactional-test-runner/src/vm_test_harness.rs
Show resolved
Hide resolved
cgswords
reviewed
Jan 18, 2025
Comment on lines
+177
to
+186
| .iter() | ||
| .find_map(|(k, v)| { | ||
| if *v == self.package_id { | ||
| Some(*k) | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| .expect("address not found in linkage table") | ||
| } |
There was a problem hiding this comment.
This seems fine to me?
There was a problem hiding this comment.
This iteration to find the root package's runtime ID seems bad, since it is so many other places (e.g., the module's runtime ID). Maybe we should store it on the package for sanity?
cgswords
reviewed
Jan 18, 2025
## Description Update how we handle deserialization errors so they maintain their specificity. Also updates a bad merge. ## Test plan CI --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
approved these changes
Jan 21, 2025
|
I'm adding the |
|
merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two commits:
HashMapfor linkage to aBTreeMap(for determinism purposes/paranoia). This transformation is pretty mechanical.root_packagefrom the linkage context, as in the new linkage story this does not make much sense.Test plan
Make sure existing tests pass.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.