[move-compiler] Improve error message for if without else #19995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
tnowacki
commented
Oct 23, 2024
| Vector(Loc, usize, Box<Type>, Box<Exp>), | ||
|
|
||
| IfElse(Box<Exp>, Box<Exp>, Box<Exp>), | ||
| IfElse(Box<Exp>, Box<Exp>, Option<Box<Exp>>), |
There was a problem hiding this comment.
We don't need this in typing just for the error message, but I am persisting it for lints
tzakian
approved these changes
Oct 23, 2024
| subtype( | ||
| context, | ||
| eloc, | ||
| || "Invalid 'if'. The body of an 'if' without an 'else' must be type '()'", |
There was a problem hiding this comment.
Very nitty nit:
Suggested change
| || "Invalid 'if'. The body of an 'if' without an 'else' must be type '()'", | |
| || "Invalid 'if'. The body of an 'if' without an 'else' must be of type '()'", |
There was a problem hiding this comment.
or ... must have type '()'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.