Show Transaction Hash of Ledger in MultiSig Toolkit #19965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "@radix-ui/react-slot": "^1.1.0", | ||
| "@radix-ui/react-tabs": "^1.1.0", | ||
| "@tanstack/react-query": "^5.50.1", | ||
| "blake2b": "link:@noble/hashes/blake2b", |
There was a problem hiding this comment.
why are we aliasing blak2b like this?
hayes-mysten
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show the Transaction Hash the user sees on the Ledger as an option for the User in the Multisig Toolkit.
Currently, any user signing a Sui transaction with a ledger has a hard time verifying the transaction they are signing is the transaction they expect to sign.
This feature provides a way for the user to verify the Transaction Hash presented by the Ledger from the MultiSig Toolkit Interface
Test plan
Tested Locally
created transaction:
Compute Transaction hash in multisig toolkit:
0x46ac3b8e4f61981f7c016e0bcb53cc2bbd4bc52f8d5e51e335e0a5dc15ab9cb5Verify same hash Ledger shows
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.