Skip to content

Conversation

ronny-mysten
Copy link
Contributor

@ronny-mysten ronny-mysten commented Oct 21, 2024

Description

Adds an NFT example to explicitly show display.

Test plan

👀


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:08am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 0:08am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 0:08am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 0:08am

@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Oct 22, 2024
@ronny-mysten ronny-mysten changed the title [docs] Ignore [docs] NFT update Oct 22, 2024
@ronny-mysten ronny-mysten requested a review from amnn October 22, 2024 15:59
@amnn
Copy link
Contributor

amnn commented Oct 23, 2024

@ronny-mysten, could we use a simpler example for the NFT that we are displaying? The current version uses Randomness, etc, which are (a) quite complicated features to introduce at this stage, and (b) there's a risk that people will use this example as a template for how to implement Randomness as well which isn't really our intention.

You should be able to demonstrate Display by adding to the existing testnet_nft example.

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 24, 2024
@ronny-mysten ronny-mysten deleted the nft-update branch February 20, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale Type: Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants