move: ignore dependency entries in manifest with resolver #19514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
rvantonder
force-pushed
the
rvt/ignore-resolver-x
branch
from
34cb2b0 to
23940cf
Compare
rvantonder
requested review from
a team,
amnn,
manolisliolios and
stefan-mysten
|
(I'm guessing this is superseded by #19561?) |
|
yep! closing in favor of #19561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #19057.
Previously when parsing the
Move.tomlwe expect that if a dependency entry contains aresolver, then it ought to contain apackagesentry, and anyotherentries would generate a warning:As of #19057 it's more appropriate to instead require no strict validation here, such that any dependency with
resolveris free to choose other entries in it's table:Test plan
Tested manually that no warning is generated for packages other than
packages. Since there aren't existing tests and this change makes the requirement less strict, and no functional uses, it's unclear if we need a rigorous test here.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.