[Indexer] A few improvements to backfill tool #19441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amnn
approved these changes
Sep 19, 2024
15 tasks
samuel-rufi
added a commit
to iotaledger/iota
that referenced
this pull request
Jul 15, 2025
# Description of change Introduces the backfill infrastructure for the indexer. Consolidates relevant upstream patches, filters out backfill workflows for unsupported database tables, and improves error handling, testing, API compatibility, progress tracking, refactoring, type & trait naming, and comments. **Upstream patches:** * [indexer: SQL Backfill command (#19359)](MystenLabs/sui#19359) {"side-effects": "major", "type": "feature"} * [Indexer: A few improvements to backfill tool (#19441)](MystenLabs/sui#19441) * [Indexer: Add a generic backfill template](MystenLabs/sui#19510) * [Indexer: Add ingestion based backfill](MystenLabs/sui#19636) * [indexer: backfill tx_affected_objects](MystenLabs/sui#19675) * [indexer: tx_affected_objects ingestion-based backfill](MystenLabs/sui@b902e82) * [Indexer: Fix a bug in epochs system state json backfill](MystenLabs/sui#19695) * [fix(backfill): chunk up writes to DB](MystenLabs/sui#19699) * [chore(indexer): drop redundant curly braces](MystenLabs/sui@a9b5784) * [chore(indexer): reduce visibility of crates](MystenLabs/sui@372f6b6) * [fix(indexer): fix default db path in SQL ingestion scripts](MystenLabs/sui@81fcff6) * [indexer: backfill for tx_affected_addresses](MystenLabs/sui@6a579d6) ## Links to any relevant issues Fixes #7365 ## How the change has been tested - [X] Basic tests (linting, compilation, formatting, unit/integration tests) - [X] Patch-specific tests (correctness, functionality coverage) ### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) This PR doesn’t touch existing ingestion pipelines or synchronization. It doesn’t include any actual backfill implementation, instead, it delivers the infrastructure and tooling needed to create backfill jobs. However, relevant patch-specific tests have been added. - [ ] Synchronization of the indexer from genesis for a network including migration objects. - [ ] Restart of indexer synchronization locally without resetting the database. - [ ] Restart of indexer synchronization on a production-like database. - [ ] Deployment of services using Docker. - [X] Verification of API backward compatibility. ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [X] Indexer: Adds a new `RunBackfill` CLI command to backfill DB tables. - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: --------- Co-authored-by: Sergiu Popescu <44298302+sergiupopescu199@users.noreply.github.com>
filipdulic
pushed a commit
to iotaledger/iota
that referenced
this pull request
Jul 16, 2025
# Description of change Introduces the backfill infrastructure for the indexer. Consolidates relevant upstream patches, filters out backfill workflows for unsupported database tables, and improves error handling, testing, API compatibility, progress tracking, refactoring, type & trait naming, and comments. **Upstream patches:** * [indexer: SQL Backfill command (#19359)](MystenLabs/sui#19359) {"side-effects": "major", "type": "feature"} * [Indexer: A few improvements to backfill tool (#19441)](MystenLabs/sui#19441) * [Indexer: Add a generic backfill template](MystenLabs/sui#19510) * [Indexer: Add ingestion based backfill](MystenLabs/sui#19636) * [indexer: backfill tx_affected_objects](MystenLabs/sui#19675) * [indexer: tx_affected_objects ingestion-based backfill](MystenLabs/sui@b902e82) * [Indexer: Fix a bug in epochs system state json backfill](MystenLabs/sui#19695) * [fix(backfill): chunk up writes to DB](MystenLabs/sui#19699) * [chore(indexer): drop redundant curly braces](MystenLabs/sui@a9b5784) * [chore(indexer): reduce visibility of crates](MystenLabs/sui@372f6b6) * [fix(indexer): fix default db path in SQL ingestion scripts](MystenLabs/sui@81fcff6) * [indexer: backfill for tx_affected_addresses](MystenLabs/sui@6a579d6) ## Links to any relevant issues Fixes #7365 ## How the change has been tested - [X] Basic tests (linting, compilation, formatting, unit/integration tests) - [X] Patch-specific tests (correctness, functionality coverage) ### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) This PR doesn’t touch existing ingestion pipelines or synchronization. It doesn’t include any actual backfill implementation, instead, it delivers the infrastructure and tooling needed to create backfill jobs. However, relevant patch-specific tests have been added. - [ ] Synchronization of the indexer from genesis for a network including migration objects. - [ ] Restart of indexer synchronization locally without resetting the database. - [ ] Restart of indexer synchronization on a production-like database. - [ ] Deployment of services using Docker. - [X] Verification of API backward compatibility. ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [X] Indexer: Adds a new `RunBackfill` CLI command to backfill DB tables. - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: --------- Co-authored-by: Sergiu Popescu <44298302+sergiupopescu199@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 3 improvements to the sql backfill tool:
Test plan
Run again locally
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.