Skip to content

Conversation

longbowlu
Copy link
Contributor

@longbowlu longbowlu commented Sep 15, 2024

Description

This PR lets Monitor subscribes to eth governance events as well. Next PR (#19389) implements the actual handling of these events.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Sep 15, 2024 6:20am
sui-kiosk ⬜️ Ignored (Inspect) Sep 15, 2024 6:20am
sui-typescript-docs ⬜️ Ignored (Inspect) Sep 15, 2024 6:20am

@longbowlu longbowlu marked this pull request as ready for review September 16, 2024 06:56
@longbowlu longbowlu changed the title eth event monitor [bridge] let monitor subscribe to eth governance events Sep 16, 2024
Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longbowlu longbowlu merged commit 5fca65a into main Sep 17, 2024
80 of 84 checks passed
@longbowlu longbowlu deleted the eth-monitor branch September 17, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants