rest: discard failed dynamic field indices #19377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Allow dynamic field indexing to fail when building up fullnode REST indices to bring it in line with behaviour in `sui-indexer`, `sui-analytics-indexer`, and the existing fullnode indices. ## Test plan CI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
bmwill
approved these changes
Sep 14, 2024
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description Allow dynamic field indexing to fail when building up fullnode REST indices to bring it in line with behaviour in `sui-indexer`, `sui-analytics-indexer`, and the existing fullnode indices. ## Test plan CI --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
8 tasks
VorobyevIlya
added a commit
to iotaledger/iota
that referenced
this pull request
Apr 29, 2025
) # Description of change Port upstream change: rest: discard failed dynamic field indices MystenLabs/sui@f286745 (PR: MystenLabs/sui#19377) > Allow dynamic field indexing to fail when building up fullnode REST > indices to bring it in line with behaviour in `sui-indexer`, > `sui-analytics-indexer`, and the existing fullnode indices. ## Links to any relevant issues Closes #6562 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
piotrm50
pushed a commit
to iotaledger/iota
that referenced
this pull request
May 21, 2025
) # Description of change Port upstream change: rest: discard failed dynamic field indices MystenLabs/sui@f286745 (PR: MystenLabs/sui#19377) > Allow dynamic field indexing to fail when building up fullnode REST > indices to bring it in line with behaviour in `sui-indexer`, > `sui-analytics-indexer`, and the existing fullnode indices. ## Links to any relevant issues Closes #6562 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
piotrm50
pushed a commit
to iotaledger/iota
that referenced
this pull request
May 21, 2025
) # Description of change Port upstream change: rest: discard failed dynamic field indices MystenLabs/sui@f286745 (PR: MystenLabs/sui#19377) > Allow dynamic field indexing to fail when building up fullnode REST > indices to bring it in line with behaviour in `sui-indexer`, > `sui-analytics-indexer`, and the existing fullnode indices. ## Links to any relevant issues Closes #6562 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
piotrm50
pushed a commit
to iotaledger/iota
that referenced
this pull request
May 28, 2025
) # Description of change Port upstream change: rest: discard failed dynamic field indices MystenLabs/sui@f286745 (PR: MystenLabs/sui#19377) > Allow dynamic field indexing to fail when building up fullnode REST > indices to bring it in line with behaviour in `sui-indexer`, > `sui-analytics-indexer`, and the existing fullnode indices. ## Links to any relevant issues Closes #6562 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
filipdulic
pushed a commit
to iotaledger/iota
that referenced
this pull request
Jul 16, 2025
) # Description of change Port upstream change: rest: discard failed dynamic field indices MystenLabs/sui@f286745 (PR: MystenLabs/sui#19377) > Allow dynamic field indexing to fail when building up fullnode REST > indices to bring it in line with behaviour in `sui-indexer`, > `sui-analytics-indexer`, and the existing fullnode indices. ## Links to any relevant issues Closes #6562 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow dynamic field indexing to fail when building up fullnode REST indices to bring it in line with behaviour in
sui-indexer,sui-analytics-indexer, and the existing fullnode indices.Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.