[GraphQL][MVR] Move to new naming standard #19376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manolisliolios
requested review from
amnn,
emmazzz,
stefan-mysten,
suiwombat and
wlmyng
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
amnn
reviewed
Sep 16, 2024
crates/sui-graphql-rpc/src/types/move_registry/named_move_package.rs
Outdated
Show resolved
Hide resolved
manolisliolios
force-pushed
the
ml/mvr-new-naming-standard
branch
from
d72f0b8 to
b72aac1
Compare
amnn
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Thanks for the quick turnaround @manolisliolios ! Given our offline chat, I'm still leaning towards /1 vs :v1 for the version identifiers, but will leave the final decision with you!
manolisliolios
force-pushed
the
ml/mvr-new-naming-standard
branch
from
e3c679f to
d4947ab
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description
Move things left and right (gets rid of the `dot_move` naming), and
update our parsing logic to use our new naming standard.
The naming standard used is `{ns_name}/{app_name}/{version}` with
`/{version}` being optional.
## Test plan
Tweaked the existing e2e & unit tests to work with the new naming
standard, and resolution works as expected on the e2e ones.
---
## Release notes
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] REST API:
manolisliolios
added a commit
that referenced
this pull request
Sep 26, 2024
Move things left and right (gets rid of the `dot_move` naming), and
update our parsing logic to use our new naming standard.
The naming standard used is `{ns_name}/{app_name}/{version}` with
`/{version}` being optional.
Tweaked the existing e2e & unit tests to work with the new naming
standard, and resolution works as expected on the e2e ones.
---
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] REST API:
manolisliolios
added a commit
that referenced
this pull request
Sep 26, 2024
Move things left and right (gets rid of the `dot_move` naming), and
update our parsing logic to use our new naming standard.
The naming standard used is `{ns_name}/{app_name}/{version}` with
`/{version}` being optional.
Tweaked the existing e2e & unit tests to work with the new naming
standard, and resolution works as expected on the e2e ones.
---
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move things left and right (gets rid of the
dot_movenaming), and update our parsing logic to use our new naming standard.The naming standard used is
{ns_name}/{app_name}/{version}with/{version}being optional.Test plan
Tweaked the existing e2e & unit tests to work with the new naming standard, and resolution works as expected on the e2e ones.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.