ci(graphql): tests for staging variant #19371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnn
requested review from
emmazzz,
stefan-mysten,
suiwombat and
wlmyng
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
amnn
changed the title
8 tasks
gegaowp
approved these changes
Sep 16, 2024
This was referenced Sep 16, 2024
## Description Set-up testing for `staging` variant of `sui-graphql-rpc`: - Split E2E tests into `stable` and `staging` variants (each in their own sub-directories -- existing tests are all `stable`). Only run the stable tests by default, and additionally run the staging tests if the `staging` feature is enabled. - Generate a separate `staging` schema and snapshot test. - Add a CI step to run GraphQL tests with the staging flag enabled. ## Test plan ``` sui$ cargo nextest run --profile ci --features staging \ -E 'package(sui-graphql-rpc)' \ -E 'package(sui-graphql-e2e-tests)' ``` And also check CI.
amnn
force-pushed
the
amnn/tx-affected-ci
branch
from
af40b5e to
1940c09
Compare
|
Is there going to be a staging directory? |
amnn
added a commit
that referenced
this pull request
Sep 17, 2024
## Description Some of these tests are on older versions because they landed around the time of the last bump. Bringing everything in line with protocol 51. ## Test plan ``` $ cargo nextest run -p sui-graphql-e2e-tests ``` ## Stack - #19371 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
|
Yes there is -- I will be adding it in #19365 |
amnn
added a commit
that referenced
this pull request
Sep 18, 2024
## Description Add `TransactionBlockFilter.affectedAddress` as a way to filter transactions by their relationship to an address without worrying about what kind of relationship that is. ## Test plan New E2E ## Stack - #19363 - #19371 - #19402 - #19403 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set-up testing for
stagingvariant ofsui-graphql-rpc:stableandstagingvariants (each in their own sub-directories -- existing tests are allstable). Only run the stable tests by default, and additionally run the staging tests if thestagingfeature is enabled.stagingschema and snapshot test.Test plan
And also check CI.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
staging.graphql. This schema includes changes that are being developed and tested but have not been productionized yet.