[suiop] module refactor #19356
Merged
[suiop] module refactor #19356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
pei-mysten
approved these changes
Sep 13, 2024
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description Refactor modules and shuffle things around to clean up the codebase and prepare for other integrations (notion) The only actual functional change is to separate the PD incident struct that's returned from the API from the more robust incident, which includes slack association and will also include notion metadata. ## Test plan Functionality remains ([example](https://mysten-labs.slack.com/archives/C03QJ1B6BC0/p1726233363961019)) --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor modules and shuffle things around to clean up the codebase and prepare for other integrations (notion)
The only actual functional change is to separate the PD incident struct that's returned from the API from the more robust incident, which includes slack association and will also include notion metadata.
Test plan
Functionality remains (example)
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.