[move-ide] Split symbolication implementation into smaller functions #19338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
cgswords
reviewed
Sep 13, 2024
cgswords
approved these changes
Sep 13, 2024
cgswords
reviewed
Sep 13, 2024
| &compiled_pkg_info, | ||
| cursor_info, | ||
| ); | ||
| cursor_context = compute_symbols_parsed_program( |
There was a problem hiding this comment.
Consider adding a comment that this skips typed computation for speed
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
…19338) ## Description This PR contains a refactoring to split a super-long `get_symbols` function into two smaller ones. It not only makes code mode readable but also enables a more optimized implementation of the test suite. Previously, all symbols had to be recomputed when tests involved a cursor, even though it was only cursor that was changing, rather than symbols themselves. With this PR, we can recompute the cursor only, which brings the time to run all `move-analyzer` tests from minutes to (tens of) seconds. ## Test plan All existing tests must pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a refactoring to split a super-long
get_symbolsfunction into two smaller ones.It not only makes code mode readable but also enables a more optimized implementation of the test suite. Previously, all symbols had to be recomputed when tests involved a cursor, even though it was only cursor that was changing, rather than symbols themselves. With this PR, we can recompute the cursor only, which brings the time to run all
move-analyzertests from minutes to (tens of) seconds.Test plan
All existing tests must pass