[trace-view] Added support for continue #19331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
awelc
commented
Sep 12, 2024
| this.frameStack.frames.pop(); | ||
| return this.step(false); | ||
|
|
||
| // Do not skip to same line when stepping out as this may lead |
There was a problem hiding this comment.
This change is unrelated to the "continue" action implementation, but it's small enough that I decided to sneak it in as part of this PR....
awelc
commented
Sep 12, 2024
| } | ||
|
|
||
| protected async launchRequest(response: DebugProtocol.LaunchResponse, args: ILaunchRequestArguments): Promise<void> { | ||
| protected async launchRequest( |
There was a problem hiding this comment.
This (and the following) formatting changes were not necessary to achieve the stated goal of this PR but will make the code look better (as a side-note, I don't like TS auto-formatter not formatting these automatically)
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description
This PR adds support for "continue" debugger action. It also makes
implementation of "next" ("step over") and "step out" actions faithful
to their intended semantics (i.e., executing all instruction in a
function stepped over or stepped out of). These changes do not actually
change the current behavior of the viewer - they are done in preparation
for implementing variable value tracking and displaying.
This PR also includes a refinement of the "step out" action
implementation. As also explained in the code comment, previously in the
following line of code, after entering `foo` and stepping out of it, we
would immediately step into `bar`, which could be quite confusing for
the user:
```
assert(foo() == bar());
```
Finally, this PR also includes some formatting changes for lines that
were a bit too long
## Test plan
Tested manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for "continue" debugger action. It also makes implementation of "next" ("step over") and "step out" actions faithful to their intended semantics (i.e., executing all instruction in a function stepped over or stepped out of). These changes do not actually change the current behavior of the viewer - they are done in preparation for implementing variable value tracking and displaying.
This PR also includes a refinement of the "step out" action implementation. As also explained in the code comment, previously in the following line of code, after entering
fooand stepping out of it, we would immediately step intobar, which could be quite confusing for the user:Finally, this PR also includes some formatting changes for lines that were a bit too long
Test plan
Tested manually