[sui-mode][move-compiler] Greatly improve shared_owned lint accuracy #19330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
tnowacki
commented
Sep 11, 2024
| // utils | ||
| //************************************************************************************************** | ||
|
|
||
| pub fn calls_special_function(special: &[(&str, &str, &str)], cfg: &ImmForwardCFG) -> bool { |
There was a problem hiding this comment.
These will be generalized a bit in the next PR
awelc
reviewed
Sep 12, 2024
| @@ -0,0 +1,106 @@ | |||
| // object is re shared, but it is never transferred and doesn't have public transfer | |||
There was a problem hiding this comment.
Is there an .exp file missing for this one?
There was a problem hiding this comment.
No, they are negative cases so they do not trigger the lint
| return None; | ||
| } | ||
| Some(ShareOwnedVerifierAI) | ||
| if !calls_special_function(SHARE_FUNCTIONS, cfg) { |
There was a problem hiding this comment.
Is this an optimization or it actually helps with accuracy?
There was a problem hiding this comment.
I wonder if it's worth an entirely separate visit and visitor modifications, but certainly a non-blocking issue for me
cgswords
reviewed
Sep 12, 2024
Comment on lines
+258
to
+266
| if self.sui_info().uid_holders.contains_key(&(m, n)) { | ||
| return true; | ||
| } | ||
| let phantom_positions = phantom_positions(self.info, &m, &n); | ||
| phantom_positions | ||
| .into_iter() | ||
| .zip(targs) | ||
| .filter(|(is_phantom, _)| !*is_phantom) | ||
| .any(|(_, t)| self.can_hold_obj_base(t)) |
There was a problem hiding this comment.
Would it be better to do this filtering step when building uid_holders, disregarding phantom types when building it?
There was a problem hiding this comment.
I can't really since I need to do this per-type instantiation.
cgswords
reviewed
Sep 12, 2024
| f: &ModuleCall, | ||
| args: Vec<Value>, | ||
| ) { | ||
| let Value::NotFreshObj(not_fresh_loc) = &args[0] else { |
There was a problem hiding this comment.
Can args[0] here ever panic?
There was a problem hiding this comment.
Not at this point, but maybe above. I'll change
cgswords
reviewed
Sep 12, 2024
| else { | ||
| return; | ||
| }; | ||
| let Some(transferred_kind) = self.sui_info().transferred.get(&tn).copied() else { |
There was a problem hiding this comment.
Is the copy here necessary, or can we get away with a borrow?
There was a problem hiding this comment.
I'll immediately copy it below, but doing so brings it inline with the other Loc usages here, so I'll do that, thanks!
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
…19330) ## Description - The share_owned lint now uses type information to try to determine if an object is "fresh" - It assumes an object is fresh if it it comes from a function with not reachable UID inputs. Since in that case, the object could wrapped or coming from a dynamic field - Improved filtering to skip this analysis in some cases ## Test plan - New tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
valeriyr
added a commit
to iotaledger/iota
that referenced
this pull request
Feb 3, 2025
[sui-mode][move-compiler] Greatly improve shared_owned lint accuracy #19330 MystenLabs/sui#19330
valeriyr
added a commit
to iotaledger/iota
that referenced
this pull request
Feb 14, 2025
…sion (#4559) * mainnet-v1.39.4 external-crates * fix: license headers * fix(move-trace-format): updated authors * fix(move-analyzer): several fixes for SVCode extension after update * fix: fix workspace build after the external crates updating * feat: create the protocol version `3` * fix(external-crates): reverted `Identifier` serialization * fix(iota-e2e-tests): fix the `basic_read_cmd_snapshot_tests` test * fix: added missed changed from the upstream PR #17991 [move][test_scenario] Fix bug in test_scenario where we weren't returning allocated tickets (#17991) MystenLabs/sui#17991 * fix: added missed changed from the upstream PR #19330 [sui-mode][move-compiler] Greatly improve shared_owned lint accuracy #19330 MystenLabs/sui#19330 * fix: added missed changed from the upstream PR 16523 move toolchain: fix multiple issues with bytecode dependencies MystenLabs/sui#16523 * cargo fmt * fix(move-analyzer): the extension tests were fixed * fix(iota-framework): compiled packages update * fix(iota-framework-snapshots): snapshots update * fix: test snapshots * fix: clippy * fix(move-analyzer): the extension tests fix * fix(external-crates): tests baseline * fix(move-analyzer): the `completion` test is ignored * fix(move-analyzer): bump the vscode extension version to 1.1.0 * feat: bump iota to v0.10.0-alpha * fix(iota): shell tests after update * fix(iota-json-rpc-tests): fixed the `get_committee_info` test * fix(iota-adapter-transactional-tests): `large_enum_v2` -> `large_enum_v3` * fix(iota-types): remove the `test-utils` feature * fix: added `move-trace-format` to `external-crates-filters.yml` * fix(iota-protocol-config): the version `4` history message * fix(docs): update the Rust examples `Cargo.lock` file * fix(external-crates): the `packages.md` file formatting * fix(iota-move-build): removed extra assert from the `development_mode_not_allowed` test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.