Skip to content

Conversation

after-ephemera
Copy link
Contributor

@after-ephemera after-ephemera commented Sep 11, 2024

Description

  • Refactor api logic into new module
  • get all users so we can select them to be points of contact
  • add multiselect to allow selection of an arbitrary set of users
  • generalize serde logic for caching api responses (once per day)
  • improve tagging of channels to link to the actual channel
  • tag associated poc users for an incident

Test plan

e2e functional (see example message)


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 9:49pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:49pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:49pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:49pm

Copy link
Contributor

@pei-mysten pei-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a nit but overall looks good!

@after-ephemera after-ephemera enabled auto-merge (squash) September 12, 2024 21:50
@after-ephemera after-ephemera merged commit 363eb01 into main Sep 12, 2024
47 of 48 checks passed
@after-ephemera after-ephemera deleted the jkj/suiop-inc-rev-pocs branch September 12, 2024 22:10
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
## Description 

- Refactor api logic into new module
- get all users so we can select them to be points of contact
- add multiselect to allow selection of an arbitrary set of users
- generalize serde logic for caching api responses (once per day)
- improve tagging of channels to link to the actual channel
- tag associated poc users for an incident

## Test plan 

e2e functional (see [example
message](https://mysten-labs.slack.com/archives/C03QJ1B6BC0/p1726147679829409))

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants