[cherry-pick][Move] Update tests to use unique addresses for different modules in tests (#19262) #19327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests (#19262) ## Description Updates tests so that unique addresses are used on modules that are not part of the same package (needed as part of the larger package loader rewrite). Note that the `0x1`, `0x2` addresses are used by the stdlib (etc.) so I bumped all addresses to start at `0x6`. Tests should largely be unchanged. The one exception is some rewriting in the `move-vm-integration-tests` as there were issues running tests, and the fact the `CompiledModule::serialize` is test-only. Once this lands, I'll rebase and land into the vm_2024 branch. ## Test plan Update existing tests, verify their outputs change as expected.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tnowacki
approved these changes
Sep 11, 2024
tzakian
deleted the
tzakian/vm-rewrite--update-tests-for-package-loader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #19262 to the vm rewrite branch.
Description
Updates tests so that unique addresses are used on modules that are not part of the same package (needed as part of the larger package loader rewrite). Note that the
0x1,0x2addresses are used by the stdlib (etc.) so I bumped all addresses to start at0x6.Tests should largely be unchanged. The one exception is some rewriting in the
move-vm-integration-testsas there were issues running tests, and the fact theCompiledModule::serializeis test-only.Once this lands, I'll rebase and land into the vm_2024 branch.
Test plan
Update existing tests, verify their outputs change as expected.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.