[Move] Box type layout vectors #19310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzakian
requested review from
amnn,
emmazzz,
mystenmark,
stefan-mysten,
suiwombat and
wlmyng
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
tnowacki
approved these changes
Sep 10, 2024
Comment on lines
+37
to
+39
| entry fun x4(): X4 { | ||
| X4::U64(0) | ||
| } |
There was a problem hiding this comment.
Funny that this is all it took to hit it still
tzakian
force-pushed
the
tzakian/box-layouts
branch
from
e1ffa26 to
e768cd8
Compare
tzakian
force-pushed
the
tzakian/box-layouts
branch
from
e768cd8 to
6b7ce71
Compare
tzakian
force-pushed
the
tzakian/box-layouts
branch
from
6b7ce71 to
ed3d6ed
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description Boxes fields in the `MoveTypeLayout` to make the enum size smaller for type layouts. ## Test plan Added test to check size of the enums + make sure existing tests pass. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [X] Protocol: Increase the maximum type layout size in the VM. Most users should not notice this change. - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
7 tasks
tzakian
pushed a commit
that referenced
this pull request
Feb 17, 2025
## Description The `MoveFieldLayout` struct `fields` was wrapped in a box as part of #19310, which states in its reasoning: > Boxes fields in the MoveTypeLayout to make the enum size smaller for type layouts. However, this field being boxed does not affect the enums which this was referring to as it is also boxed in the variants. This means that the variant size of those enums is always the size of a pointer. Thus, this additional box around the vec serves only to create an additional indirection. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
DaughterOfMars
added a commit
to iotaledger/iota
that referenced
this pull request
Mar 3, 2025
The `MoveFieldLayout` struct `fields` was wrapped in a box as part of MystenLabs/sui#19310, which states in its reasoning: > Boxes fields in the MoveTypeLayout to make the enum size smaller for type layouts. However, this field being boxed does not affect the enums which this was referring to as it is also boxed in the variants. This means that the variant size of those enums is always the size of a pointer. Thus, this additional box around the vec serves only to create an additional indirection.
DaughterOfMars
added a commit
to iotaledger/iota
that referenced
this pull request
Mar 4, 2025
The `MoveFieldLayout` struct `fields` was wrapped in a box as part of MystenLabs/sui#19310, which states in its reasoning: > Boxes fields in the MoveTypeLayout to make the enum size smaller for type layouts. However, this field being boxed does not affect the enums which this was referring to as it is also boxed in the variants. This means that the variant size of those enums is always the size of a pointer. Thus, this additional box around the vec serves only to create an additional indirection.
Ginowine
pushed a commit
to iotaledger/iota
that referenced
this pull request
Mar 11, 2025
The `MoveFieldLayout` struct `fields` was wrapped in a box as part of MystenLabs/sui#19310, which states in its reasoning: > Boxes fields in the MoveTypeLayout to make the enum size smaller for type layouts. However, this field being boxed does not affect the enums which this was referring to as it is also boxed in the variants. This means that the variant size of those enums is always the size of a pointer. Thus, this additional box around the vec serves only to create an additional indirection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Boxes fields in the
MoveTypeLayoutto make the enum size smaller for type layouts.Test plan
Added test to check size of the enums + make sure existing tests pass.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.