Skip to content

Conversation

after-ephemera
Copy link
Contributor

@after-ephemera after-ephemera commented Sep 10, 2024

Description

Introduces some breaking changes, trying to see if anything yells.

Test plan

Counting on signals for this one. None of the breaking changes listed in the itertools changelog appear anywhere in our codebase based on grepping for them.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@after-ephemera after-ephemera requested review from a team and bmwill September 10, 2024 21:30
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 2:57pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 2:57pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 2:57pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 2:57pm

@after-ephemera after-ephemera merged commit dec33d0 into main Sep 11, 2024
49 checks passed
@after-ephemera after-ephemera deleted the jkj/bump-itertools branch September 11, 2024 16:44
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
## Description 

Introduces some [breaking
changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md),
trying to see if anything yells.

## Test plan 

Counting on signals for this one. None of the breaking changes listed in
the itertools changelog appear anywhere in our codebase based on
grepping for them.

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants