[benchmark] Count tx as success only if effects are ok #19235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mwtian
approved these changes
Sep 6, 2024
| .inc_by(num_commands as u64); | ||
| } else { | ||
| metrics_cloned | ||
| .num_error |
There was a problem hiding this comment.
Maybe add a label for execution vs rpc failures? Or use a separate metric?
arun-koshy
added a commit
that referenced
this pull request
Sep 6, 2024
Follow up to this [comment](#19235 (comment))
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
This is more of an issue now that we have congestion control mechanisms in place where transactions can get cancelled after consensus. We also have not run our benchmark suite routinely to push these more congested scenarios so we have not run into this issue before,
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
Follow up to this [comment](#19235 (comment))
6 tasks
bingyanglin
added a commit
to iotaledger/iota
that referenced
this pull request
May 4, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
bingyanglin
added a commit
to iotaledger/iota
that referenced
this pull request
May 19, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
bingyanglin
added a commit
to iotaledger/iota
that referenced
this pull request
May 20, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
muXxer
pushed a commit
to iotaledger/iota
that referenced
this pull request
May 28, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
muXxer
pushed a commit
to iotaledger/iota
that referenced
this pull request
May 28, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
muXxer
pushed a commit
to iotaledger/iota
that referenced
this pull request
May 28, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
muXxer
pushed a commit
to iotaledger/iota
that referenced
this pull request
Jun 2, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
muXxer
pushed a commit
to iotaledger/iota
that referenced
this pull request
Jun 2, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
filipdulic
pushed a commit
to iotaledger/iota
that referenced
this pull request
Jul 16, 2025
# Description of change Port MystenLabs/sui@53244c1 From [Sui's commit description] Follow up to this [comment](MystenLabs/sui#19235 (comment)) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [x] I have followed the contribution guidelines for this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of an issue now that we have congestion control mechanisms in place where transactions can get cancelled after consensus. We also have not run our benchmark suite routinely to push these more congested scenarios so we have not run into this issue before,