[SDK] Adds .move plugin
#19194
Merged
[SDK] Adds .move plugin
#19194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hayes-mysten
reviewed
Sep 3, 2024
hayes-mysten
reviewed
Sep 3, 2024
sdk/typescript/src/transactions/plugins/NameResolutionPlugin.ts
Outdated
Show resolved
Hide resolved
sdk/typescript/src/transactions/plugins/NameResolutionPlugin.ts
Outdated
Show resolved
Hide resolved
sdk/typescript/src/transactions/plugins/NameResolutionPlugin.ts
Outdated
Show resolved
Hide resolved
hayes-mysten
reviewed
Sep 6, 2024
hayes-mysten
reviewed
Sep 6, 2024
manolisliolios
force-pushed
the
ml/dot-move-ts-plugin
branch
from
2f79205 to
e71945f
Compare
hayes-mysten
reviewed
Sep 9, 2024
hayes-mysten
reviewed
Sep 9, 2024
manolisliolios
force-pushed
the
ml/dot-move-ts-plugin
branch
from
65e231d to
0fed76b
Compare
hayes-mysten
approved these changes
Sep 10, 2024
| for (const t of splitType) { | ||
| if (t.includes(NAME_SEPARATOR) && !isValidNamedPackage(t)) return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
not a blocker, but this isn't really validating that the type is a valid format, only that the namedType part is. At some point it would probably good if this returned false if you just pass in a package name, or have mis matching angle brackets, etc...
manolisliolios
force-pushed
the
ml/dot-move-ts-plugin
branch
from
0fed76b to
d9731aa
Compare
manolisliolios
force-pushed
the
ml/dot-move-ts-plugin
branch
from
d9731aa to
32b7d51
Compare
manolisliolios
force-pushed
the
ml/dot-move-ts-plugin
branch
from
32b7d51 to
e247e1c
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description Introduces the TS plugin that will be used for replacing names with actual addresses. ## Test plan Currently contains unit tests. Once we have a live setup (mainnet / testnet), we'll also setup an actual e2e test (similar to zksend). --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: --------- Co-authored-by: Michael Hayes <michael.hayes@mystenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the TS plugin that will be used for replacing names with actual addresses.
Test plan
Currently contains unit tests. Once we have a live setup (mainnet / testnet), we'll also setup an actual e2e test (similar to zksend).
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.