Skip to content

Conversation

Bridgerz
Copy link
Contributor

@Bridgerz Bridgerz commented Aug 30, 2024

Description
Account for Eth block re-orgs in eth indexer #19158

Test plan
Spot check on my local machine. Indexer validity checker tool coming soon...

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 5:07pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:07pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:07pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 5:07pm

Copy link
Contributor

@longbowlu longbowlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an easy way to write a test for this change?

@longbowlu
Copy link
Contributor

longbowlu commented Aug 30, 2024

now we want to keep syncing "live" finalized events, we do want a live_task, right? (we have disable_live_task today)

Copy link
Contributor

@longbowlu longbowlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate test the new insert query?

@Bridgerz Bridgerz merged commit c2687c0 into main Sep 13, 2024
48 checks passed
@Bridgerz Bridgerz deleted the bridge-indexer-eth-reorgs branch September 13, 2024 21:57
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
Description
Account for Eth block re-orgs in eth indexer #19158

Test plan
Spot check on my local machine. Indexer validity checker tool coming
soon...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants