[framework] Marks sui::url as deprecated
#19123
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
damirka
force-pushed
the
ds/deprecate-url
branch
from
87b50d4 to
659d177
Compare
| // Copyright (c) Mysten Labs, Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| #[allow(deprecated_usage)] |
There was a problem hiding this comment.
A bit ridiculous, but every function in the sui::url uses the deprecated Url type. 😆
There was a problem hiding this comment.
@tzakian, I wonder if we should just suppress deprecation usage within the same package... Or maybe somehow with public functions? Not sure.
My point is that these warnings here are not-actionable. We cannot break the API
There was a problem hiding this comment.
Hmmm I'm of two minds on it.
One one hand warning about deprecations on APIs that you cannot change is quite annoying. On the other hand, this might be the only way folks find out about the deprecation, and that they may want to add new functions that use the new type (etc).
I kinda would lean towards the second opinion the most here (we should warn, and folks need to manually turn it off).
|
@tnowacki so deprecation of type makes more sense. The case that I was most worried is creating new coins. By deprecating the type and allowing It's good to go in my opinion. |
|
Closing this PR, replacing with a task to handle sometime this year. |
3 participants
Description
We're deprecating this module for now.
Test plan
Not much to test.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.