Deepbook Indexer #19023
Merged
Deepbook Indexer #19023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Bridgerz
force-pushed
the
deepbook-indexer
branch
from
35b0e72 to
f05f768
Compare
Bridgerz
force-pushed
the
deepbook-indexer
branch
from
a4941f0 to
89f5fbe
Compare
Bridgerz
force-pushed
the
deepbook-indexer
branch
from
5ae08d2 to
bc9a430
Compare
Bridgerz
force-pushed
the
deepbook-indexer
branch
from
2a0faad to
6083bec
Compare
Bridgerz
force-pushed
the
deepbook-indexer
branch
from
6083bec to
70b7457
Compare
patrickkuo
approved these changes
Aug 28, 2024
longbowlu
reviewed
Sep 9, 2024
| @@ -0,0 +1,398 @@ | |||
| // Copyright (c) Mysten Labs, Inc. | |||
There was a problem hiding this comment.
i'd suggest to create a types.rs and move things over and make lib.rs very lean
| pub sender: String, | ||
| pub checkpoint: i64, | ||
| pub package: String, | ||
| pub status: String, |
There was a problem hiding this comment.
I highly recommend to use integer to represent status v.s. String (and we should fix this in bridge indexer). The former is very error prone
Bridgerz
force-pushed
the
deepbook-indexer
branch
from
7a07ac5 to
2a37333
Compare
Bridgerz
force-pushed
the
deepbook-indexer
branch
from
69600fb to
6eba422
Compare
longbowlu
force-pushed
the
deepbook-indexer
branch
from
6eba422 to
9e648f8
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description Deepbook indexer ## Test plan Will add Unit tests --------- Co-authored-by: Aslan Tashtanov <aslan.tashtanov@mystenlabs.com> Co-authored-by: 0xaslan <161349919+0xaslan@users.noreply.github.com> Co-authored-by: longbowlu <zl9394@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deepbook indexer
Test plan
Will add Unit tests