Simplify future code cleaning when python versions go out of support

[MusicalNinjaDad]

fixes #34

Allows us to rely on test coverage to identify when we can remove code in place to handle older versions of python.

Summary by Sourcery

Enhancements:

• Removes contextlib.suppress blocks for conditional imports.

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request simplifies type-checking by removing the conditional import of typing.Self and the use of contextlib.suppress. This change allows relying on test coverage to identify when code related to older Python versions can be removed.

Updated class diagram for MagicFinder

classDiagram
    class MagicFinder {
        - lineno: int
        - col_offset: int
        + __init__(self, *args, **kwargs)
        + visit(self, node: ast.AST) -> Any
        + visit_Call(self, node: ast.Call) -> Any
        + visit_Name(self, node: ast.Name) -> Any
        + visit_Attribute(self, node: ast.Attribute) -> Any
    }

Loading

File-Level Changes

Change	Details	Files
Removed contextlib.suppress and conditional import of typing.Self for type-checking.	Removed from contextlib import suppress. Removed conditional import of Self from typing using contextlib.suppress.	pytest_ipynb2/_parser.py pytest_ipynb2/_pytester_helpers.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#34	Update codecov to consolidate reports from all versions tested	❌	The PR does not contain any changes related to codecov configuration or reporting.
#34	Wrap relevant code in if sys.version <	✅
#34	Check consistent use of < and not <= etc. and Update any comments to include "sys.version <"	❌	The PR does not explicitly check or update comments related to version comparisons.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0b2aac6) to head (7117f7f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          340       340           
  Branches        30        30           
=========================================
  Hits           340       340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sourcery-ai]

Hey @MusicalNinjaDad - I've reviewed your changes - here's some feedback:

Overall Comments:

• It's good to see the TYPE_CHECKING block being simplified by removing the suppress context manager.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟡 Review instructions: 2 issues found
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}