Skip to content

Conversation

parth-rathod
Copy link
Contributor

@parth-rathod parth-rathod commented Jun 11, 2025

Description

The test cases which were written are being converted to Pytest framework.
The unit test code was repeated too many times in test_utils.py file.
Only thing we are trying here is to run get_config() function with different types of Input data formats.
This thing can be easily achieved by pytest parametrize

  • A proper coding standard has been followed.
  • Easy to understand what type of formats are supported just by looking at the tests/data folder.
  • From 800 lines of code to just around 300 lines. Reducing eye cancer 😁

Fixes #39

How Has This Been Tested?

Run pytest

Checklist:

✅ I have performed a self-review of my own code
✅ I have commented my code, particularly in hard-to-understand areas
✅ I have made corresponding changes to the documentation
✅ My changes generate no new warnings
✅ I have added tests that prove my fix is effective or that my feature works
✅ New and existing unit tests pass locally with my changes
✅ Any dependent changes have been merged and published in downstream modules

@parth-rathod parth-rathod mentioned this pull request Jun 11, 2025
Copy link
Owner

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, amazing for @parth-rathod

Thanks 🤝

@Mr-Sunglasses Mr-Sunglasses merged commit cf70100 into Mr-Sunglasses:master Jun 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Pytest

2 participants