Skip to content

Conversation

corentin-prigent
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.31%. Comparing base (1468096) to head (63745ae).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #309      +/-   ##
===========================================
+ Coverage    50.27%   50.31%   +0.04%     
===========================================
  Files          177      177              
  Lines        47853    47857       +4     
  Branches     10355    10352       -3     
===========================================
+ Hits         24059    24081      +22     
+ Misses       16065    16041      -24     
- Partials      7729     7735       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taupalosaurus
Copy link
Contributor

taupalosaurus commented Jul 17, 2025

For future references:

  • current initialisation is wrong, as in the loop indices make no sense. Fix consist in resetting the tag only for vertices belonging to triangles in the list, which is a lot faster than resetting it for all vertices of all triangles.
  • some variable names are made more explicit throughout the function.

@corentin-prigent corentin-prigent merged commit a518faf into MmgTools:develop Jul 18, 2025
26 checks passed
@corentin-prigent corentin-prigent deleted the feature/fix-tagdel-init branch July 18, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants