-
-
Notifications
You must be signed in to change notification settings - Fork 123
New option -fem
replacing -nofem
#298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
corentin-prigent
wants to merge
18
commits into
MmgTools:develop
Choose a base branch
from
corentin-prigent:feature/split-nonrid-edg-connecting-rid-pts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New option -fem
replacing -nofem
#298
corentin-prigent
wants to merge
18
commits into
MmgTools:develop
from
corentin-prigent:feature/split-nonrid-edg-connecting-rid-pts
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecting feature points (ridge or non-manifold)
…com:corentin-prigent/mmg into feature/split-nonrid-edg-connecting-rid-pts
…tive, the test is ( if (mesh->info.fem) )
…-connecting-rid-pts
…-connecting-rid-pts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #298 +/- ##
===========================================
- Coverage 50.31% 50.31% -0.01%
===========================================
Files 177 177
Lines 47881 47894 +13
Branches 10362 10368 +6
===========================================
+ Hits 24093 24097 +4
- Misses 16047 16054 +7
- Partials 7741 7743 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update removes the option
-nofem
and adds a new option-fem
which takes an integer as a parameter:-fem 0
mimics the exact behaviour of-nofem
.-fem 1
is the default behaviour: mmg forces the output mesh to be finite element compatible.-fem 2
adds the option to also prevent the creation of regular boundary edges linking two features points (ridges or non-manifold). This stems from PR Force the split of regular boundary edges connecting ridge or non-manifold vertices #229.