-
Notifications
You must be signed in to change notification settings - Fork 92
tests: Add distill tests and CI #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d-distill-tests
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, LGTM
self.device = device | ||
return self | ||
|
||
def __call__(self, *args: Any, **kwargs: Any) -> Any: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One cool addition could be to either make the configurable, or make the seed of the rand depend on the input data. This makes tests a lot more reproducible and predictable. Anyway, just a small thing.
Something like an MD5 hash of the input_ids as a tuple, or maybe just the sum? Idk
tests/test_distillation.py
Outdated
|
||
model_name = "mock-model" | ||
|
||
if vocabulary is None and use_subword == False: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not use_subword
No description provided.