Skip to content

tests: Add distill tests and CI #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 27, 2024
Merged

tests: Add distill tests and CI #42

merged 21 commits into from
Sep 27, 2024

Conversation

Pringled
Copy link
Member

No description provided.

@Pringled Pringled requested a review from stephantul September 27, 2024 08:21
@Pringled Pringled changed the title testsL Add distill tests tests: Add distill tests Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@Pringled Pringled changed the title tests: Add distill tests tests: Add distill tests and CI Sep 27, 2024
Copy link
Member

@stephantul stephantul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM

self.device = device
return self

def __call__(self, *args: Any, **kwargs: Any) -> Any:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cool addition could be to either make the configurable, or make the seed of the rand depend on the input data. This makes tests a lot more reproducible and predictable. Anyway, just a small thing.

Something like an MD5 hash of the input_ids as a tuple, or maybe just the sum? Idk


model_name = "mock-model"

if vocabulary is None and use_subword == False:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not use_subword

@Pringled Pringled merged commit 232c9e6 into main Sep 27, 2024
4 checks passed
@Pringled Pringled deleted the add-distill-tests branch September 27, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants