Skip to content

feat: make normalization dependent on spacing #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

feat: make normalization dependent on spacing #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion model2vec/tokenizer/normalizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,18 @@
:param tokenizer: The tokenizer to change.
:return: The tokenizer with a replaced normalizer.
"""
spaces_punctuation = tokenizer.encode("a, ,", add_special_tokens=False).tokens
if len(spaces_punctuation) != 3:
add_space = False

Check warning on line 23 in model2vec/tokenizer/normalizer.py

View check run for this annotation

Codecov / codecov/patch

model2vec/tokenizer/normalizer.py#L23 

Added line #L23 was not covered by tests
else:
_, first_comma, second_comma = spaces_punctuation
add_space = first_comma == second_comma == ","

normalizer = tokenizer.normalizer
new_normalizers = []
for char in punctuation:
new_normalizers.append(Replace(char, f" {char} "))
replacement = f" {char} " if add_space else f"{char} "
new_normalizers.append(Replace(char, replacement))

new_normalizers.append(Replace(Regex(r"\s+"), " "))
new_normalizers.append(Strip(right=True))
Expand Down