Skip to content

fix: missing unk, fix bug #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

fix: missing unk, fix bug #251

merged 3 commits into from
May 28, 2025

Conversation

stephantul
Copy link
Member

The unk was missing and I also introduced a huge bug, both are fixed.

@stephantul stephantul changed the title Fix missing unk fix: missing unk, fix bug May 27, 2025
@stephantul stephantul requested a review from Pringled May 27, 2025 09:30
@codecov Codecov
Copy link

codecov bot commented May 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/tokenizer/tokenizer.py 64.28% 5 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/tokenizer/model.py 100.00% <100.00%> (ø)
model2vec/tokenizer/tokenizer.py 90.41% <64.28%> (-2.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pringled
Pringled approved these changes May 27, 2025
View reviewed changes
@stephantul stephantul merged commit c4b8254 into main May 28, 2025
5 of 6 checks passed
@stephantul stephantul deleted the fix-missing-unk branch May 28, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pringled Pringled Pringled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephantul @Pringled