Skip to content

bug: fix 0 score in evaluate #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

bug: fix 0 score in evaluate #226

merged 1 commit into from
Apr 28, 2025

Conversation

stephantul
Copy link
Member

The evaluation report was returning zeros for all classes if the class labels weren't numeric.

@stephantul stephantul requested a review from Pringled April 27, 2025 19:23
@codecov Codecov
Copy link

codecov bot commented Apr 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/inference/model.py 92.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pringled
Pringled approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@stephantul stephantul merged commit 2d0417d into main Apr 28, 2025
6 checks passed
@stephantul stephantul deleted the fix-bug-in-evaluate branch April 28, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pringled Pringled Pringled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephantul @Pringled