Skip to content

fix: pretokenize tokens before checking vocabulary #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

fix: pretokenize tokens before checking vocabulary #215

merged 1 commit into from
Apr 21, 2025

Conversation

stephantul
Copy link
Member

This fixes the issue with the vocabulary from #209

@stephantul stephantul requested a review from Pringled April 20, 2025 13:33
@codecov Codecov
Copy link

codecov bot commented Apr 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/distill/distillation.py 88.88% 1 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/distill/distillation.py 94.11% <88.88%> (-0.62%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephantul stephantul merged commit 4cc6148 into main Apr 21, 2025
5 of 6 checks passed
@stephantul stephantul deleted the fix-duplicate-tokens branch April 21, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pringled Pringled Pringled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephantul @Pringled