Add CSP nonce support for flamegraph rendering #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrav3nz
force-pushed
the
kyle/flamegraph-nonce
branch
2 times, most recently
from
80f12c2 to
4230256
Compare
The flamegraph page was missing CSP nonce attributes on its inline script tags, causing Content Security Policy violations when nonces were configured. This change extracts the nonce retrieval logic into a shared method and applies it consistently to both the main profiler UI and flamegraph pages.
xrav3nz
force-pushed
the
kyle/flamegraph-nonce
branch
from
4230256 to
487e5fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flamegraph page was missing CSP nonce attributes on its inline script tags, causing Content Security Policy violations when nonces were configured, leading to a blank page when trying to view flamegraphs.
This PR extracts the nonce retrieval logic into a shared method and applies it consistently to both the main profiler UI and flamegraph pages.