Skip to content

[Commands] Fix corruption when trying to use restartandplay under certain conditions #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

ScribbleTAS
Copy link
Member

@ScribbleTAS ScribbleTAS commented Jun 4, 2025

This happens when savestate 0 does not exist and trying to use restartandplay

Reported by ACatThatCanParkourReallyWell9900

…tain conditions

This happens when savestate 0 does not exist and trying to use restartandplay
@github-project-automation github-project-automation bot moved this to Todo in TASmod Jun 4, 2025
@ScribbleTAS ScribbleTAS requested a review from PancakeTAS June 4, 2025 07:17
@ScribbleTAS ScribbleTAS self-assigned this Jun 4, 2025
@ScribbleTAS ScribbleTAS added Savestates Issue is related to savestates Core Issue relates to core concepts labels Jun 4, 2025
@ScribbleTAS ScribbleTAS moved this from Todo to In Progress in TASmod Jun 4, 2025
TASmod.LOGGER.catching(e);
if (e.getMessage() != null) {
sender.sendMessage(new TextComponentString(TextFormatting.RED + "Could not load the initial savestate: " + e.getMessage()));
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do better logging for the loadstate exception at some point, when I redo all the command messages and add i18n

@ScribbleTAS ScribbleTAS merged commit a938c7d into MinecraftTAS:develop Jun 4, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in TASmod Jun 4, 2025
@ScribbleTAS ScribbleTAS deleted the fix/restart branch June 4, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue relates to core concepts Savestates Issue is related to savestates
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants