Skip to content

Add code format checking #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 17, 2025
Merged

Add code format checking #235

merged 8 commits into from
Apr 17, 2025

Conversation

ScribbleTAS
Copy link
Member

@ScribbleTAS ScribbleTAS commented Apr 16, 2025 •
edited
Loading

What can go wrong?

  • Adds spotless
  • Adds my current code formatter to the repo
  • Adds the import groupings
  • Add workflow for checking the formatting
  • Add notice to CONTRIBUTING.md
  • [Savestates] Move SavestateMotionStorage into builtin package

@github-project-automation github-project-automation bot moved this to Todo in TASmod Apr 16, 2025
@ScribbleTAS ScribbleTAS added the Core Issue relates to core concepts label Apr 16, 2025
@ScribbleTAS ScribbleTAS requested a review from PancakeTAS April 16, 2025 22:05
@ScribbleTAS ScribbleTAS marked this pull request as ready for review April 16, 2025 22:05
@ScribbleTAS ScribbleTAS self-assigned this Apr 16, 2025
@ScribbleTAS ScribbleTAS added this to the Beta1 milestone Apr 16, 2025
@ScribbleTAS
Copy link
Member Author

Surprisingly, even with the amount of changes, there is no merge conflict...

@ScribbleTAS ScribbleTAS moved this from Todo to In Progress in TASmod Apr 17, 2025
@ScribbleTAS
Minor improvements
26c5b6f 
- [Savestates] Move SavestateMotionStorage into builtin package
PancakeTAS
PancakeTAS approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@PancakeTAS PancakeTAS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing could possibly go wrong... good luck

@ScribbleTAS ScribbleTAS merged commit 4cebcef into MinecraftTAS:develop Apr 17, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in TASmod Apr 17, 2025
@ScribbleTAS ScribbleTAS deleted the spotless branch April 17, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PancakeTAS PancakeTAS PancakeTAS approved these changes

Assignees

@ScribbleTAS ScribbleTAS

Labels
Core Issue relates to core concepts
Projects
TASmod
Archived in project
Milestone
Beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@ScribbleTAS @PancakeTAS