Skip to content

[CI] Introduce scopes in place of mode #17500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 21, 2025

Conversation

dkijania
Copy link
Member

@dkijania dkijania commented Jul 8, 2025

Introducing fine grainier way to organize jobs in our CI. Before we had only two modes:

  • Stable -> where all jobs are run
  • Pull Request -> where only triaged jobs are run

The problem was that there were no fluent way of composing modes (how we are picking up job) and stage ( is it PR, Stable, NIghtly etc.)

My refactoring had a two outcomes. First I detached mode and introduced JobSelection constant which defines if we are triaging or not.

Second, I introduced list of scope for each test instead of enum. Now each job can define what is the scope of this test. Available are:

@dkijania
Copy link
Member Author

dkijania commented Jul 9, 2025

!ci-nightly-me

@dkijania
Copy link
Member Author

dkijania commented Jul 9, 2025

!ci-build-me

@coveralls
Copy link

coveralls commented Jul 9, 2025

Coverage Status

coverage: 61.236%. first build
when pulling 2189226 on dkijania/introduce_job_scope_instead_of_mode
into 6b5156e on compatible.

@dkijania dkijania force-pushed the dkijania/introduce_job_scope_instead_of_mode branch from 7478d0c to 3cdc952 Compare July 9, 2025 17:32
@dkijania
Copy link
Member Author

dkijania commented Jul 9, 2025

!ci-build-me

@dkijania dkijania marked this pull request as ready for review July 9, 2025 17:32
@dkijania dkijania requested a review from a team as a code owner July 9, 2025 17:32
@dkijania
Copy link
Member Author

!ci-build-me

2 similar comments
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-nightly-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania force-pushed the dkijania/introduce_job_scope_instead_of_mode branch from 5439f7e to 2189226 Compare July 16, 2025 20:46
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-nightly-me

@dkijania
Copy link
Member Author

@dkijania
Copy link
Member Author

@dkijania dkijania merged commit cd747c6 into compatible Jul 21, 2025
57 checks passed
@dkijania dkijania deleted the dkijania/introduce_job_scope_instead_of_mode branch July 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants