Skip to content

Mina_base: reactivate tests from account.ml and move to Alcotest #17499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: compatible
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

No description provided.

@dannywillems dannywillems requested a review from a team as a code owner July 8, 2025 17:20
Quickcheck.test
(let open Quickcheck in
let open Generator.Let_syntax in
(* The amount to be vested after the cliff time must be greater than zero
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is removed

in
let timing = Account.Timing.of_record timing_rec in
let vesting_end = Account.timing_final_vesting_slot timing in
(* Global_slot addition may overflow, so we need to make sure it won't happen. *)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is removed

Quickcheck.test
(let open Quickcheck.Generator.Let_syntax in
let%bind timing = gen_timing in
(* After this slot the value of vesting decrement to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is removed

~initial_minimum_balance:t.initial_minimum_balance ~start_slot ~end_slot
|> Balance.of_uint64

(* Test that the timed account generator only generates accounts that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is removed

@glyh glyh added the enhancement Not big enough to be a feature, but is a smaller improvement label Jul 9, 2025
@dannywillems dannywillems marked this pull request as draft July 9, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Not big enough to be a feature, but is a smaller improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants