Push sig kind out of integration test lib and batch txn tool #17488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
changed the title
|
!ci-build-me |
cjjdespres
requested changes
Jul 16, 2025
| @@ -967,12 +966,12 @@ let sign_and_send_payment ~logger node_uri | |||
| send_payment_with_raw_sig ~logger node_uri ~sender_pub_key ~receiver_pub_key | |||
| ~amount ~fee ~nonce ~memo ~valid_until ~raw_signature | |||
|
|
|||
| let must_sign_and_send_payment ~logger node_uri | |||
| let _must_sign_and_send_payment ~logger node_uri | |||
There was a problem hiding this comment.
This is completely unused? You might as well remove it, then, since it's so simple.
cjjdespres
approved these changes
Jul 16, 2025
|
!ci-bypass-changelog |
|
!ci-build-me |
|
Rebasing on to |
glyh
force-pushed
the
lyh/sig-kind-graphql-requests
branch
from
d4ad309 to
8e00387
Compare
|
!ci-build-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy