Changes get_server to gracefully quit when an SMTP exception occurs #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmailSenderalready does quite a good job of gracefully quitting the SMTP connection when an error occurs. However, in case the error occurs duringget_server(e.g. an authentication failure), the connection is not properly terminated.This PR wraps get_server in an exception handler that catches such exceptions and quits the connection. Keeping the connection open (until the socket is closed by GC) is not necessary as users can not access it anymore, as it is not stored in the
EmailSenderinstance.(Found while testing Red Mail in RosettaTest)