Update CreateColorProfileFromLogColorSpace to steer people away from a memory leak
#2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om memory leak The documentation indicates that you should use `GlobalFree` on the value stored at the address given by `pProfile`. In other words, ```c BYTE* pProfile = NULL; CreateProfileFromLogColorSpaceW(..., &pProfile); GlobalFree((HGLOBAL)pProfile); ``` This is wrong, it is a memory leak. If you do this 65,536 times in a row then this method will start returning `ERROR_NOT_ENOUGH_MEMORY`. Apparently that's the maximum number of `HGLOBAL`s you can have. The correct pattern is this: ```c BYTE* pProfile = NULL; CreateProfileFromLogColorSpaceW(..., &pProfile); HGLOBAL hProfile = GlobalHandle(pProfile); GlobalFree(hProfile); ``` I ran into this issue while working on my desktop app. I had a bug in a caching layer that was causing my color profile caching to not work, so it was recreating the profile on every call into the cache. After using the app for a few minutes it would crash because I convert Win32 errors into .NET exceptions. cc @Sergio0694
|
@rickbrew : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
rickbrew
changed the title
CreateColorProfileFromLogColorSpaceW to steer people away from a memory leakCreateColorProfileFromLogColorSpace to steer people away from a memory leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation indicates that you should use
GlobalFreeon the value stored at the address given bypProfile.In other words,
This is wrong, it is a memory leak. If you do this 65,536 times in a row then this method will start returning
ERROR_NOT_ENOUGH_MEMORY. Apparently that's the maximum number ofHGLOBALs you can have.The correct pattern is this:
I ran into this issue while working on my desktop app. I had a bug in a caching layer that was causing my color profile caching to not work, so it was recreating the profile on every call into the cache. After using the app for a few minutes it would crash because I convert Win32 errors into .NET exceptions.
cc @Sergio0694