-
Notifications
You must be signed in to change notification settings - Fork 320
Update to httpCompression attributes #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
17c4e8a
Update to httpCompression attributes
remcoeissing e0fe4fd
Update compression settings description for IIS versions
Rick-Anderson af79e34
Apply suggestions from code review
Rick-Anderson 5fead6c
Update ms.date in httpCompression index.md
wadepickett 57ea2ea
Revert Update ms.date in httpCompression index.md
wadepickett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -207,8 +207,8 @@ These attributes can only be configured at server level. Configuration at a site | |
| Element | Description | | ||
| --- | --- | | ||
| [`scheme`](scheme.md) | Optional element. <br><br>Specifies the compression scheme (Gzip or Deflate) IIS uses to compress client requests. This element can only be configured at server level. | | ||
| [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. This element can be configured at site level. | | ||
| [`staticTypes`](statictypes/index.md) | Optional element. <br><br>Specifies configuration settings for static compression. This element can be configured at site level. | | ||
| [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. For IIS 10.0 and later, can only be configured at the site level. Versions prior to IIS 10.0, can only be configured at the server level. | | ||
| [`staticTypes`](statictypes/index.md) | Optional element. <br><br>Specifies configuration settings for static compression. For IIS 10.0 and later, can only be configured at the site level. Versions prior to IIS 10.0, can only be configured at the server level. | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly, here we should say "For IIS versions prior to IIS 10.0, can only be configured at the server level. For IIS 10.0 and later, can also be configured at the site level."
Rick-Anderson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
### Configuration Sample | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sentence "For IIS 10.0 and later, can only be configured at the site level. Versions prior to IIS 10.0, can only be configured at the server level" indicates that
dynamicTypes
settings cannot be used at server level on IIS 10+. That's not correct and even default IIS 10 configuration file containsdynamicTypes
at server level.I suggest we change it to "For IIS versions prior to IIS 10.0, can only be configured at the server level. For IIS 10.0 and later, can also be configured at the site level."