Skip to content

Don't log same snippets (per system) twice #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

Don't log same snippets (per system) twice #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nixpkgs_review/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ def remove_ansi_escape_sequences(text: str) -> str:

def html_logs_section(logs_dir: Path, packages: list[Attr], system: str) -> str:
res = ""
seen_tails = set()
for pkg in packages:
tail = remove_ansi_escape_sequences(
get_file_tail(logs_dir / get_log_filename(pkg, system))
Expand All @@ -96,7 +97,10 @@ def html_logs_section(logs_dir: Path, packages: list[Attr], system: str) -> str:
if not res:
res = "\n---\n"
res += f"<details>\n<summary>Error logs: `{system}`</summary>\n"
if tail in seen_tails:
continue
res += f"<details>\n<summary>{pkg.name}</summary>\n<pre>{tail}</pre>\n</details>\n"
seen_tails.add(tail)
res += "</details>\n"
return res

Expand Down